Open
Conversation
kiseln
reviewed
Sep 12, 2024
|
|
||
| async function updateAdminProxy(ethereumConfig, newAdmin) { | ||
| const privateKey = hre.network.config.accounts[0]; | ||
| const signerWallet = new hre.ethers.Wallet(privateKey, hre.ethers.provider); |
Contributor
There was a problem hiding this comment.
I think this from the other script is equivalent and an easier way to get the signer
const [signerWallet] = await hre.ethers.getSigners();
Contributor
Author
There was a problem hiding this comment.
It returns HardhatEthersSigner, but I need Wallet.
Contributor
There was a problem hiding this comment.
Signer seem to be enough for all subsequent uses of this object
kiseln
reviewed
Sep 12, 2024
olga24912
commented
Oct 3, 2024
| .connect(signerWallet) | ||
| .grantRole("0x0000000000000000000000000000000000000000000000000000000000000000", newAdmin); | ||
| console.log(`Grant Admin Role for ${newAdmin} Tx Hash: ${tx_grant_admin.hash}`); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We need to wait for the transaction to complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.