Conversation
frolvanya
approved these changes
Feb 26, 2025
karim-en
approved these changes
Mar 1, 2025
kiseln
approved these changes
Mar 4, 2025
mitinarseny
reviewed
Mar 5, 2025
| #[serde(crate = "near_sdk::serde")] | ||
| pub enum Role { | ||
| // Previous role that could both pause and unpause | ||
| // PauseManager, |
Collaborator
There was a problem hiding this comment.
You should never remove a variant or add one more in the middle of enums with #[derive(AccessControlRole)], since it uses bitflags to store permissions for each AccountId.
Please, fix the migration guide.
Collaborator
There was a problem hiding this comment.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the single
manager_rolesattribute with separatepause_rolesandunpause_rolesattributes in the Pausable plugin. This enables assigning different permissions for pausing and unpausing features.Implementation
pausable.rstrait and implementation to support separate role specificationsUsage
Impact
Breaking change that requires code updates when upgrading. This enables more granular security policies, particularly in scenarios where emergency pausing should be available to more accounts than unpausing.
Pausable: add pause & unpause roles #124