Merged
Conversation
Collaborator
|
noticed the same recently and fixed it locally changing how actions are created within the library, made a PR to fix it #20 This way we can avoid requiring people to import |
GregProuty
approved these changes
Aug 26, 2025
Collaborator
GregProuty
left a comment
GregProuty
left a comment
There was a problem hiding this comment.
Looks good, thanks for noticing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, we noticed that the current examples don’t run as-is with chainsig.js unless the action is wrapped inside createAction. Ideally, libraries should be interoperable without this extra step. We’re adding this PR to make the examples work smoothly out of the box, so others can have an easier experience running them.