Potential fix for code scanning alert no. 2: Workflow does not contain permissions#34
Merged
NeckBeardPrince merged 1 commit intomainfrom Feb 13, 2026
Merged
Potential fix for code scanning alert no. 2: Workflow does not contain permissions#34NeckBeardPrince merged 1 commit intomainfrom
NeckBeardPrince merged 1 commit intomainfrom
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This pull request adds explicit permissions to the CI workflow to address a security code scanning alert. The change grants minimal required permissions (contents: read) to prevent accidental privilege escalation if repository default permissions change in the future.
Changes:
- Added a
permissions:block to.github/workflows/ci.ymlgrantingcontents: readat the workflow level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/NeckBeardPrince/howtfdoi/security/code-scanning/2
In general, the fix is to define an explicit
permissions:block that grants the minimal required GitHub token permissions, either at the workflow root (applies to all jobs that don’t override it) or per-job. This documents the workflow’s needs and prevents accidental privilege escalation if repository defaults change.For this workflow, none of the active jobs (
buildandcross-compile) perform write operations against the repository, issues, or pull requests; they only need to read the contents to build. The actions used (actions/checkout,actions/setup-go,actions/upload-artifact) all function withcontents: readand do not require additional scopes. Therefore, the best fix is to add a root-levelpermissions:block directly under thename: CIline, grantingcontents: readonly. This automatically covers thecross-compilejob (and thebuildjob and any uncommented future jobs) without changing their functionality.Concretely:
Edit
.github/workflows/ci.yml.After line 1 (
name: CI), insert:Leave the rest of the workflow unchanged.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.