ES-422 review comment fixes #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
* MOSIP-30419 Fixed update count Issue Signed-off-by: kameshsr <kameshsr1338@gmail.com> * MOSIP-30420 Fixed update identity issue Signed-off-by: kameshsr <kameshsr1338@gmail.com> --------- Signed-off-by: kameshsr <kameshsr1338@gmail.com>
* MOSIP-30420 Added validation in update identity API. Signed-off-by: kameshsr <kameshsr1338@gmail.com> Signed-off-by: Loganathan Sekar <m1047627@mindtree.com> * -sAdded null check Signed-off-by: kameshsr <kameshsr1338@gmail.com> Signed-off-by: Loganathan Sekar <m1047627@mindtree.com> * Combined 2 if condition Signed-off-by: kameshsr <kameshsr1338@gmail.com> Signed-off-by: Loganathan Sekar <m1047627@mindtree.com> * Update IdRepoServiceImpl.java Signed-off-by: Loganathan Sekar <m1047627@mindtree.com> --------- Signed-off-by: kameshsr <kameshsr1338@gmail.com> Signed-off-by: Loganathan Sekar <m1047627@mindtree.com> Co-authored-by: Loganathan Sekar <42532387+LoganathanSekar7627@users.noreply.github.com>
Signed-off-by: kameshsr <kameshsr1338@gmail.com>
* MOSIP-30419 Removed update count for update draft Signed-off-by: kameshsr <kameshsr1338@gmail.com> * MOSIP-30419 Refactored code Signed-off-by: kameshsr <kameshsr1338@gmail.com> --------- Signed-off-by: kameshsr <kameshsr1338@gmail.com>
* MOSIP-30592 Fixed update count issue Signed-off-by: kameshsr <kameshsr1338@gmail.com> * MOSIP-30592 Added missing attributes from policy for update count Signed-off-by: kameshsr <kameshsr1338@gmail.com> --------- Signed-off-by: kameshsr <kameshsr1338@gmail.com>
Signed-off-by: Neha Farheen <m1092365@mindtree.com>
Signed-off-by: Neha Farheen <m1092365@mindtree.com>
Signed-off-by: Neha Farheen <m1092365@mindtree.com>
Signed-off-by: Neha Farheen <m1092365@mindtree.com>
Signed-off-by: ase-101 <sunkadaeanusha@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.