-
Notifications
You must be signed in to change notification settings - Fork 0
Components questions #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: refactoring
Are you sure you want to change the base?
Conversation
| @@ -1,7 +1,11 @@ | |||
| .container { | |||
| position: relative; | |||
| top: 55px; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean margin-top
|
|
||
| const Footer = () => ( | ||
| <footer className={styles.footer}> | ||
| <a href="/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean Link
| .header { | ||
| position: absolute; | ||
| position: relative; | ||
| top: 30px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean margin-top and margin-left
|
|
||
| import styles from '../Questions.scss'; | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra line
| <div className={styles.questions__head}> | ||
| <div className={styles['questions__head-create']}> | ||
| <Button theme="white" onClick={goBack}> | ||
| Назад |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l18n
|
|
||
| return new Promise((resolve) => { | ||
| Web3Service.createTxData(address, rawTx, maxGasPrice) | ||
| // eslint-disable-next-line max-len |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
| import Button from '../Button/Button'; | ||
| import { CreateToken } from '../Icons'; | ||
| import Question from './Question'; | ||
| import styles from './Questions.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move styles down
| MemoryRouter, Route, Switch, | ||
| } from 'react-router-dom'; | ||
| import Login from '../Login'; | ||
| // import Login from '../Login'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomment
| import React, { Component } from 'react'; | ||
| import propTypes from 'prop-types'; | ||
| import { DropdownArrowIcon } from '../Icons'; | ||
| import styles from '../Dropdown/Dropdown.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move styles down
| async checkIsQuestionsUploaded(address) { | ||
| const { Web3Service, contractService } = this.rootStore; | ||
| const abi = JSON.parse(fs.readFileSync(path.join(PATH_TO_CONTRACTS, './Voter.abi'), 'utf8')); | ||
| const contract = Web3Service.createContractInstance(abi); | ||
| contract.options.address = address; | ||
| contractService.setContract(contract); | ||
| const { countOfUploaded, totalCount } = await contractService.checkQuestions(); | ||
| return countOfUploaded > totalCount; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move it to ContractServices
No description provided.