Skip to content

Recreate widget on log/relog && Add Scriptable trim conditions#24

Open
Fiskmans wants to merge 10 commits intoNerdpuff:masterfrom
Fiskmans:master
Open

Recreate widget on log/relog && Add Scriptable trim conditions#24
Fiskmans wants to merge 10 commits intoNerdpuff:masterfrom
Fiskmans:master

Conversation

@Fiskmans
Copy link
Copy Markdown

@Fiskmans Fiskmans commented Jan 6, 2026

Closes #23

I may have gone a little hard on the refactoring, let me know if you want a version that is just the fix

Notably something i did fixed a ~half second delay when the trims first appear, but i don't know what exactly

Fiskmans and others added 4 commits January 6, 2026 14:15
@Fiskmans
Refactor:
eb8d682 
Only use one widget per skill and change the spriteId as needed instead
Use runelite.api 'Skill' more directly where applicable
Trimmed some intermediary classes (MockTrimState && MaxSkillTrimWidget) that are no longer used as a result
Resulting in much snappier behaviour
@Fiskmans
Reset trim on logout/login
47db2de 
Closes Nerdpuff#23
Scriptable trims wip
b9ab685
Scriptable trims
6f956a5
@Fiskmans
Copy link
Copy Markdown
Author

Fiskmans commented Jan 8, 2026 •
edited
Loading

@Nerdpuff
I've got another few changes, that depend on this merge. do you want me to update the pullrequest or would you prefer to do it as independent pulls?

@Fiskmans Fiskmans changed the title Recreate widget on log/relog Recreate widget on log/relog && Add Scriptable trim conditions Jan 28, 2026
@Fiskmans
Copy link
Copy Markdown
Author

Fiskmans commented Jan 28, 2026

Screencast.From.2026-01-28.19-48-35.mp4

@Fiskmans
Copy link
Copy Markdown
Author

Fiskmans commented Jan 28, 2026

Closes #10
Closes #14

Screencast.From.2026-01-28.22-22-35.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Trims are not reapplied on a relog

1 participant

@Fiskmans