refactor: Harvest dashboards should use consistent line width and sho…

[cgrinds]

…w points

[Copilot]

Pull request overview

This PR standardizes Grafana timeseries panel rendering across the Harvest dashboards, primarily targeting consistent line/point styling, and adds a repository-level test to enforce those defaults going forward.

Changes:

• Update many dashboards to set fieldConfig.defaults.custom.showPoints to "never" (from "auto") and align various lineWidth values to 1.
• Remove/adjust a few panel-specific overrides while refactoring visualization defaults.
• Add a Go test (TestTimeSeriesDefaults) to validate timeseries defaults across all dashboards.

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
grafana/dashboards/storagegrid/tenant.json	Set timeseries showPoints default to "never".
grafana/dashboards/storagegrid/s3.json	Set timeseries showPoints default to "never" in multiple panels.
grafana/dashboards/storagegrid/overview.json	Set timeseries showPoints default to "never" in multiple panels.
grafana/dashboards/eseries/volume.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/eseries/ssd_cache.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/eseries/hardware.json	Set timeseries showPoints default to "never" for affected panels.
grafana/dashboards/eseries/controller.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/eseries/array.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/workload.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/vscan.json	Set timeseries showPoints default to "never".
grafana/dashboards/cmode/volume.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/timetillfull.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/switch.json	Set timeseries showPoints default to "never".
grafana/dashboards/cmode/svm.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/snapmirror_destinations.json	Set timeseries showPoints default to "never".
grafana/dashboards/cmode/smb.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/s3ObjectStorage.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/qtree.json	Reduce lineWidth to 1 and set showPoints to "never" in affected panels.
grafana/dashboards/cmode/node.json	Set timeseries showPoints default to "never"; adjust some lineWidth values to 1.
grafana/dashboards/cmode/nfsTroubleshooting.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/network.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/metadata.json	Set timeseries showPoints default to "never" and remove a series override block.
grafana/dashboards/cmode/mcc_cluster.json	Reduce lineWidth to 1 across affected panels.
grafana/dashboards/cmode/disk.json	Change override matcher and remove bar-style override properties; keep showPoints at "never" in defaults.
grafana/dashboards/cmode/datacenter.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/cluster.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/cdot.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/aggregate.json	Set timeseries showPoints default to "never" and reduce lineWidth to 1 in affected panels.
grafana/dashboards/cmode/lun.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/headroom.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/flexgroup.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode/flexcache.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cmode-details/volumeDeepDive.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/cisco/cisco.json	Set timeseries showPoints default to "never".
grafana/dashboards/7mode/volume7.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/7mode/node7.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/7mode/network7.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/7mode/lun7.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/7mode/disk7.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/7mode/cluster7.json	Set timeseries showPoints default to "never" across panels.
grafana/dashboards/7mode/aggregate7.json	Set timeseries showPoints default to "never" across panels.
cmd/tools/grafana/dashboard_test.go	Add TestTimeSeriesDefaults to validate timeseries defaults/overrides.

Comments suppressed due to low confidence (1)

grafana/dashboards/cmode/disk.json:2721

• The override for the HDD Reads Replaced series no longer forces bar rendering (custom.drawStyle="bars", fillOpacity=100, lineWidth=0) and now only adjusts unit/axis label. This will change the panel visualization from bars to a line/area, which may reduce readability for an RPS-like metric. If bars are still desired, reintroduce the drawStyle/fill/lineWidth override and adjust the new timeseries-defaults test to allow lineWidth=0 when drawStyle is "bars".

            "overrides": [
              {
                "matcher": {
                  "id": "byFrameRefID",
                  "options": "B"
                },
                "properties": [
                  {
                    "id": "unit",
                    "value": "short"
                  },
                  {
                    "id": "custom.axisLabel",
                    "value": "HDD Reads Replaced"
                  }
                ]

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.