Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds snapshot policy management capabilities: updating a snapshot policy and adding/updating/removing schedule entries within an existing snapshot policy, plus related schema/model updates and integration coverage.
Changes:
- Extend snapshot policy models to support
enabledandcomment, and introduce a snapshot-policy schedule-entry input type. - Add server-side MCP tools for updating snapshot policies and managing schedule entries inside a policy.
- Add REST client support for snapshot policy update and schedule-entry CRUD, and add/adjust integration tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tool/tool.go | Extends tool input schemas for snapshot policy fields and snapshot-policy schedule-entry operations. |
| server/Snapshotpolicy.go | Adds handlers/validators for update snapshot policy + add/update/remove schedule entries in a policy. |
| server/server.go | Registers new MCP tools for snapshot policy updates and schedule-entry CRUD. |
| rest/snapshotpolicy.go | Implements REST calls for snapshot policy create/update/delete and schedule-entry add/update/remove. |
| ontap/ontap.go | Extends ONTAP models for snapshot policy enabled/comment and schedule-entry payloads; augments GetData record shape. |
| integration/test/snapshotPolicy_test.go | Adds integration scenarios for schedule-entry CRUD and snapshot policy update. |
| integration/test/snapshot_test.go | Removes the prior snapshot test (replaced by snapshotPolicy_test). |
| descriptions/descriptions.go | Adds tool descriptions for the new snapshot policy and schedule-entry operations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rahulguptajss
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.