-
Notifications
You must be signed in to change notification settings - Fork 18
Add support for Rocky Linux 10.1 #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pranavcracker
wants to merge
5
commits into
main
Choose a base branch
from
feat/rocky_10.1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -159,6 +159,7 @@ services: | |
| - modulename: nf_defrag_ipv6 | ||
| install: '{{ nodes[0]["internal_address"] | isipv6 }}' | ||
| rhel9: *modprobe-default-modules | ||
| rhel10: *modprobe-default-modules | ||
| debian: *modprobe-default-modules | ||
|
|
||
| sysctl: | ||
|
|
@@ -502,6 +503,20 @@ services: | |
| package_name: 'policycoreutils-python-utils' | ||
| iptables: | ||
| package_name: 'iptables-nft' | ||
| rhel10: | ||
| containerd: {} | ||
| haproxy: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to check HAProxy/keepalived versions on rhel10 |
||
| executable_name: '/usr/sbin/haproxy' | ||
| service_name: 'haproxy' | ||
| keepalived: {} | ||
| audit: | ||
| package_name: 'audit' | ||
| conntrack: | ||
| package_name: 'conntrack-tools' | ||
| semanage: | ||
| package_name: 'policycoreutils-python-utils' | ||
| iptables: | ||
| package_name: 'iptables-nft' | ||
|
|
||
| plugin_defaults: | ||
| installation: {} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -341,6 +341,27 @@ def disable_swap(group: NodeGroup) -> Optional[RunnersGroupResult]: | |
| def reboot_nodes(cluster: KubernetesCluster) -> None: | ||
| cluster.get_new_nodes_or_self().call(reboot_group) | ||
|
|
||
| def detect_kernel_upgrade(group: NodeGroup) -> List[str]: | ||
pranavcracker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| cluster = group.cluster | ||
| affected_hosts = [] | ||
|
|
||
| os_family = group.get_nodes_os() | ||
|
|
||
| if os_family in ["rhel8", "rhel9", "rhel10"]: | ||
pranavcracker marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| try: | ||
| result = group.sudo("needs-restarting -r", hide=True, warn=True) | ||
| for host, res in result.items(): | ||
| if res.exited == 1: | ||
| affected_hosts.append(host) | ||
| cluster.log.debug( | ||
| f"{host}: Reboot required (detected via needs-restarting -r)" | ||
| ) | ||
| except GroupResultException: | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we mock this in tests? I am not sure about always ignoring GroupResultException |
||
| cluster.log.debug( | ||
| "Skipping reboot detection (needs-restarting not available in test environment)" | ||
| ) | ||
| return [] | ||
| return affected_hosts #list of nodes with detected kernel upgrade | ||
|
|
||
| def reboot_group(group: NodeGroup, try_graceful: bool = None) -> RunnersGroupResult: | ||
| from kubemarine import kubernetes # pylint: disable=cyclic-import | ||
|
|
@@ -497,7 +518,7 @@ def verify_system(cluster: KubernetesCluster) -> None: | |
| # this method handles clusters with multiple OS | ||
| os_family = group.get_nodes_os() | ||
|
|
||
| if os_family in ['rhel8', 'rhel9'] and cluster.is_task_completed('prepare.system.setup_selinux'): | ||
| if os_family in ['rhel8', 'rhel9', 'rhel10'] and cluster.is_task_completed('prepare.system.setup_selinux'): | ||
| log.debug("Verifying Selinux...") | ||
| selinux_configured, selinux_result, _ = \ | ||
| selinux.is_config_valid(group, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.