Skip to content

feat: do not post routes if mesh type is istio #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
estetsenko wants to merge 3 commits into
base: main
Choose a base branch
from

Merge branch 'main' into feat/do-not-post-routes-if-istio

cc92f90
Select commit
Loading
Failed to load commit list.
Open

feat: do not post routes if mesh type is istio #4

Merge branch 'main' into feat/do-not-post-routes-if-istio
cc92f90
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 1m 23s

Quality Gate failed

Failed conditions
67.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 18 in core-rest-libraries/route-registration/route-registration-common/src/main/java/com/netcracker/cloud/routesregistration/common/service/TopologyConfigService.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor your code to get this URI from a customizable parameter. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ0FgeuvuLbE7AhQnF4P&open=AZ0FgeuvuLbE7AhQnF4P&pullRequest=4

Check warning on line 109 in core-quarkus-extensions/routes-registrator/runtime/src/main/java/com/netcracker/cloud/quarkus/routesregistration/runtime/gateway/route/RouteRegistrationConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this use of "setProperties"; it is deprecated. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ0FgeseuLbE7AhQnF4N&open=AZ0FgeseuLbE7AhQnF4N&pullRequest=4

Check warning on line 24 in core-quarkus-extensions/routes-registrator/runtime/src/main/java/com/netcracker/cloud/quarkus/routesregistration/runtime/gateway/route/RouteRegistrationConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reorder the modifiers to comply with the Java Language Specification. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ0FgeseuLbE7AhQnF4M&open=AZ0FgeseuLbE7AhQnF4M&pullRequest=4

Check warning on line 8 in core-rest-libraries/route-registration/route-registration-common/src/main/java/com/netcracker/cloud/routesregistration/common/gateway/route/Utils.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a private constructor to hide the implicit public one. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ0FgeuluLbE7AhQnF4O&open=AZ0FgeuluLbE7AhQnF4O&pullRequest=4

Check warning on line 47 in core-rest-libraries/route-registration/route-registration-common/src/test/java/com/netcracker/cloud/routesregistration/common/service/TopologyConfigServiceTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace these 3 tests with a single Parameterized one. 

See more on https://sonarcloud.io/project/issues?id=Netcracker_qubership-core-java-libs&issues=AZ0FgevuuLbE7AhQnF4Q&open=AZ0FgevuuLbE7AhQnF4Q&pullRequest=4
View more details on SonarQubeCloud