Draft
Conversation
* feat: ExternalDatabaseDeclaration CRD * feat: added dbaas-client * feat: added externaldatabasedeclaration controller * feat: wip externaldatabasedeclaration * feat: added error handling for DBaaS responses * feat: added k8s test examples * feat: added leader election * feat: added read creds from dbaas secret * feat: hot secret reload * feat: added events * feat: added ObservedGeneration * feat: setup backoff for requeue * feat: added tmf error handling * feat: adding unit tests, updating declarativepayload * fix: removing redundant code in tests * feat: added tmf response from library * fix: Adapter-specific extra properties are merged first so that typed fields below always take precedence over them * test: Adapter-specific extra properties are merged first so that typed fields below always take precedence over them * fix: validate Secret keys before building aggregator request If a referenced Secret exists but is missing the username or password key, the controller now returns an explicit error instead of silently sending empty credentials to dbaas-aggregator. * docs: clarify observedGeneration semantics for BackingOff state * chore: regenerate CRD manifests * fix: making sure 401 cannot be returned as a client error * feat: adding a sample CR for external db testing * refactor: move to resty in dbaas client * refactor: removed explisit host, port, authDbName from ExternalDatabaseDeclaration * refactor: credentials reading separated * chore: garbage removed * refactor: statuses and conditions * refactor: DBAAS_AGGREGATOR_URL is optional now * refactor: emulator renamed to dbaas-aggregator * refactor: removed deprecated api * fix: build * fix: renamed phases --------- Co-authored-by: Abhimanyu Roy <abhimanyuroy3197@gmail.com>
6f99b1b to
02cae4d
Compare
* feat: databasedeclaration processing * refactor(controller): unify status transitions and fix EDB 4xx handling * refactor(client): centralize aggregator error decoding * refactor(controller): split external database request assembly * refactor(test): extract shared controller test helpers * refactor(controller): simplify database declaration state handling * refactor(controller): centralize status patch lifecycle * refactor(controller): move shared condition constants * refactor(test): add shared controller sync fixtures * refactor(api): replace observedGeneration type switch with interface * fix(controller): use errors.As result directly; expand condition comments * fix(api): exclude ObservedGenerationSetter interface from controller-gen
* fix(api): rename TrackingId → TrackingID per Go naming conventions * fix(api): replace non-standard omitzero tag with omitempty * refactor(api): move TrackingID out of shared OperatorStatus into DatabaseDeclarationStatus * fix(controller): align LastTransitionTime with Kubernetes API conventions * test(controller): add unit tests for setCondition LastTransitionTime behavior * docs(controller): sync setCondition comments with actual LastTransitionTime behavior * refactor(client): remove dead IsClientError method * refactor(controller): extract shared handleAggregatorError helper * refactor(controller): name the inline DbPolicy aggregator spec type * refactor(mock): read request body once in logRequest, pass to handlers * refactor(controller): extract shared invalidSpec helper * test(controller): delegate DD reconcileAndFetch to shared helper; add GinkgoHelper() * refactor(controller): convert clearPendingOperation and markProvisioningStarted to package functions * refactor(client): unify JSON decoding in GetOperationStatus with ApplyConfig * fix(controller): resubmit on TERMINATED instead of permanent failure * fix(controller): report SecretError for empty credential values in Secret * fix(controller): remove trackingID from Ready condition message
* chore: upgrade Go to 1.26.1 * chore: switch to qubership-core-base runtime image
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.