Fixes Issue #127 - Add command-line overrides#152
Open
ajmath wants to merge 3 commits intoNetflix:masterfrom
Open
Fixes Issue #127 - Add command-line overrides#152ajmath wants to merge 3 commits intoNetflix:masterfrom
ajmath wants to merge 3 commits intoNetflix:masterfrom
Conversation
|
aminator-pull-requests #122 SUCCESS |
Author
|
This currently only works for plugin configurations. You can use like this |
Contributor
|
@matheeeny Thanks for the PR. We're a little backlogged in reviewing/testing, but this looks pretty helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127
I had to split up the configure method on PluginBase into configure and initialize. Initialize is now called in the PluginManager constructor and then after command line args are parsed, a new method is called on PluginManager which calls configure in each of the plugins. Without splitting this up, config values could be used in the configure method to populate member variables before they were overridden (i.e. plugins.blockdevice.linux).