Skip to content

Conversation

@B3rs
Copy link

@B3rs B3rs commented Jun 25, 2018

After an error in listener.Accept() remote object can be nil.

remote, err := listener.Accept()

Calling remote.Close() in this line causes a panic.
remote.Close()

We noticed this behaviour because this error Error accepting connection from remote: accept tcp [::]:11211: accept4: too many open files causes our implementation to panic.

Since the wanted behavior is to continue the listener.Accept() loop in case of error, we should wrap this particular remote.Close() call with an if remote != nil statement

Fixes #129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant