Open
Conversation
ElijahVlasov
requested review from
NiDimi,
cupicmarko,
frozenspider and
maksimryndin
as code owners
| fn from_with_cfg(value: $t, cfg: &Self::Config) -> Self { | ||
| let abs: BoxedUint = value.into(); | ||
| let abs = abs.resize(cfg.modulus().bits_precision()); | ||
| Self(BoxedMontyForm::new(abs, cfg.clone())) |
Collaborator
There was a problem hiding this comment.
Not sure we actually want this inlined, it's rather long
| fn from_with_cfg(value: &crypto_bigint::Uint<LIMBS>, cfg: &Self::Config) -> Self { | ||
| let value: BoxedUint = value.into(); | ||
| let value = value.resize(cfg.modulus().bits_precision()); | ||
| Self(BoxedMontyForm::new(value, cfg.clone())) |
| #[inline(always)] | ||
| fn modulus_minus_one_div_two(&self) -> Self::Inner { | ||
| let value = self.0.params().modulus().clone().get(); | ||
| (value - BoxedUint::one()) / NonZero::new(BoxedUint::from(2_u8)).unwrap() |
| impl<const LIMBS: usize, const LIMBS2: usize> FromWithConfig<&Int<LIMBS2>> for MontyField<LIMBS> { | ||
| #[allow(clippy::arithmetic_side_effects)] // False alert | ||
| #[inline(always)] | ||
| fn from_with_cfg(value: &Int<LIMBS2>, cfg: &Self::Config) -> Self { |
| impl<const LIMBS: usize, const LIMBS2: usize> FromWithConfig<&Uint<LIMBS2>> for MontyField<LIMBS> { | ||
| #[allow(clippy::arithmetic_side_effects)] // False alert | ||
| #[inline(always)] | ||
| fn from_with_cfg(value: &Uint<LIMBS2>, cfg: &Self::Config) -> Self { |
| #[allow(clippy::arithmetic_side_effects)] // False alert | ||
| #[inline(always)] | ||
| fn modulus_minus_one_div_two(&self) -> Self::Inner { | ||
| let value = self.0.params().modulus().get(); |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The methods of monty fields are mostly delegates so let's inline(always) probably?