GUI Tests #32
GUI Tests #32
Conversation
PeggyBrown
left a comment
PeggyBrown
left a comment
There was a problem hiding this comment.
Please make the Travis build green 😉
Also, maybe some .idea files should be ignored?
| @@ -0,0 +1,13 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
this file shouldn't be in repository, please update .gitignore
| @@ -0,0 +1,14 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| @@ -0,0 +1,124 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <version>1.0.4</version> | ||
| </dependency> | ||
|
|
||
| <!--Poniżej biblioteki konieczne do poprawnego działania Allure framework--> |
There was a problem hiding this comment.
please use english comments here and in other places
| throw new RuntimeException("Cannot load properties due to IOException!"); | ||
| } finally { | ||
|
|
||
| closeResource(inputStream); |
There was a problem hiding this comment.
instead of manually closing the stream you could use try-with-resources statement:
https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html
| @Severity(SeverityLevel.MINOR) | ||
| @Description("The goal of this test is to check the correctness of a comment addition") | ||
| public void addComment() { | ||
| DriverUtils.navigateToPage("http://basia-komp:8000/#/conference/51"); |
There was a problem hiding this comment.
Magic string, which will work only in your local environment. I suggest to get the base URL from properties, keep a list of constants for subpages and build full URLs from these two sources.
| DriverUtils.navigateToPage("http://basia-komp:8000/#/conference/51"); | ||
| //HomePage.goToConfitura2018(); | ||
|
|
||
| Confitura2018 loginPage = new Confitura2018(); |
There was a problem hiding this comment.
is it really loginPage? I mean I'm confused comparing the name of the class and the name of the argument.
| @Severity(SeverityLevel.CRITICAL) | ||
| @Description (".") | ||
|
|
||
| public void Import() { |
There was a problem hiding this comment.
don't get what this test does or check. Could you please explain?
| @BeforeMethod | ||
| public void beforeTest(@Optional BrowserType browserType) { | ||
| DriverManager.setWebDriver(browserType); | ||
| DriverManager.getWebDriver(); |
There was a problem hiding this comment.
unnecessary line (or am I wrong?)
|
|
||
| public class TestBase { | ||
|
|
||
| private Logger logger1 = LogManager.getLogger(TestBase.class); |
|
Two general comments:
|
3 participants
POM + first simple test