feat(scan): test ids as strings #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR converts test identifiers from being based on the TestType enum to using strings throughout the codebase. The change simplifies test configuration by replacing enum values with their string equivalents.
- Updated all examples, tests, and configurations to use string test ids (e.g. "xss" instead of TestType.CrossSiteScripting).
- Removed the TestType enum along with its related validation and serialization tests.
Reviewed Changes
| File | Description |
|---|---|
| src/SecTester.Runner/README.md | Updated code snippets and documentation to use string test ids. |
| test/SecTester.Scan.Tests/Commands/CreateScanTests.cs | Modified tests to use string test ids. |
| test/SecTester.Scan.Tests/DefaultScanFactoryTests.cs | Adjusted scan configuration tests to use strings. |
| test/SecTester.Scan.Tests/ScanSettingsTests.cs | Updated tests to reflect string-based test ids and adjusted error validations. |
| test/SecTester.Scan.Tests/ScanSettingsBuilderTests.cs | Updated builder tests to use strings. |
| src/SecTester.Scan/README.md | Updated documentation examples to demonstrate string test ids. |
| src/SecTester.Scan/ScanSettings.cs | Refactored ScanSettings to accept IEnumerable and removed enum-based validation. |
| src/SecTester.Scan/Models/ScanConfig.cs | Changed scan configuration property to use string test ids. |
| test/SecTester.Scan.Tests/MessageSerializerTests.cs | Removed obsolete enum serialization tests for test types. |
| src/SecTester.Scan/ScanSettingsBuilder.cs | Updated builder implementation to use string test ids. |
| test/SecTester.Runner.Tests/SecScanTests.cs | Revamped tests to use string test ids. |
| test/SecTester.Runner.Tests/SecRunnerTests.cs | Updated test scan builder usage to use strings. |
| test/SecTester.Scan.Tests/DefaultScansTests.cs | Adjusted tests to reflect string test id usage. |
| src/SecTester.Scan/Models/TestType.cs | Removed the TestType enum as part of the conversion. |
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
derevnjuk
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.