fix(stellar): unify agent secret env var and correct futurenet passphrase #37
Merged
robertocarlous merged 2 commits intoNeurowealth:mainfrom Mar 31, 2026
Merged
fix(stellar): unify agent secret env var and correct futurenet passphrase #37robertocarlous merged 2 commits intoNeurowealth:mainfrom
robertocarlous merged 2 commits intoNeurowealth:mainfrom
Conversation
|
@manoahLinks Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STELLAR_AGENT_SECRET_KEYas the single env var name across config, client, tests, docs, and.env.example— eliminates silent runtime failures from mismatched variable namesgetNetworkPassphrase()to explicitly mapfuturenet→Networks.FUTURENETinstead of falling through toTESTNET; throws a clear error for unknown network valuesTest plan
getAgentKeypair()succeeds when onlySTELLAR_AGENT_SECRET_KEYis setSTELLAR_AGENT_SECRETorAGENT_SECRET_KEYgetNetworkPassphrase()returns correct passphrase for futurenetnpm run lintpassesCloses #29
Closes #31