Build theme settings page (dark/light/system) with persistence#97
Merged
Abidoyesimze merged 3 commits intoNeurowealth:mainfrom Mar 29, 2026
Merged
Build theme settings page (dark/light/system) with persistence#97Abidoyesimze merged 3 commits intoNeurowealth:mainfrom
Abidoyesimze merged 3 commits intoNeurowealth:mainfrom
Conversation
|
@Nemenwq Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly fix conflict @Nemenwq |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've successfully built the theme settings page with full persistence and system preference support. Here's what was implemented:
✅ Key Features Delivered:
Three Theme Options: Light, Dark, and System (follows OS preference)
Settings Page: Added "Appearance" section to /dashboard/settings/preferences
Persistence: localStorage saves theme choice, survives browser refresh
No Flash: CSS transitions ≤ 200ms prevent theme flicker on load
System Integration: Automatically syncs with OS dark/light mode preference
Immediate Updates: Theme changes apply instantly without page reload
🎨 Design Compliance:
Theme buttons meet 44px minimum height requirement
Smooth transitions prevent visual jarring
Uses existing WCAG AA compliant color tokens
Consistent with existing settings page design
🔧 Technical Implementation:
ThemeProvider: New context provider managing theme state with system preference detection
Updated Components: ThemeToggle now uses centralized theme management
CSS Transitions: Added smooth color transitions to prevent flash
TypeScript Support: Full type safety with ThemeMode enum
The theme settings are now live and ready for use. Users can access them through Dashboard → Settings → Preferences → Appearance section.
Closes #79