Skip to content

Feature/ci workflow consolidation and enhancements#77

Merged
Abidoyesimze merged 4 commits intoNeurowealth:mainfrom
pope-h:feature/ci-workflow-consolidation-and-enhancements
Mar 29, 2026
Merged

Feature/ci workflow consolidation and enhancements#77
Abidoyesimze merged 4 commits intoNeurowealth:mainfrom
pope-h:feature/ci-workflow-consolidation-and-enhancements

Conversation

@pope-h
Copy link
Copy Markdown
Contributor

@pope-h pope-h commented Mar 28, 2026

Consolidate CI + enforce lints + test cleanup + view helpers

Closes #67
Closes #68
Closes #69
Closes #70

What changed

CI

  • Consolidated overlapping GitHub Actions workflows into a single CI workflow with a matrix:
    • fmt (cargo fmt --all -- --check)
    • clippy (cargo clippy --all-targets --all-features -- -D warnings)
    • tests (workspace tests once; removes duplicate test runs)
    • build-wasm (MVP-compatible build + wasm-opt)
  • Added caching for:
    • Cargo registry/git/bin
    • ~/.local/bin (downloaded soroban binary)
    • cargo-installed tools (e.g. wasm-opt)
  • Fixed workflow reachability by adding workflow_dispatch + schedule (required by e2e-devnet job conditional)

Tests

  • Migrated legacy inline #[cfg(test)] mod tests out of contracts/vault/src/lib.rs into contracts/vault/src/tests/test_legacy_inline.rs
  • Ensures cargo test runs through the unified suite in src/tests/ (no split coverage / duplicate suites)

New read-only helpers

  • Added:
    • get_user_info(user) -> { principal, shares }
    • preview_deposit_to_shares(amount)
    • preview_shares_to_assets(shares)
  • Added tests for:
    • bootstrap behavior
    • yield + rounding consistency against existing conversion helpers

Verification

  • cargo test (vault crate) passes
  • cargo clippy --all-targets --all-features -- -D warnings passes

@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 28, 2026

@pope-h Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Abidoyesimze Abidoyesimze merged commit 7e249c9 into Neurowealth:main Mar 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants