Skip to content

Derive isRecording from coordinator state machine #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Newarr wants to merge 3 commits into from
Closed

Derive isRecording from coordinator state machine #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27fd880
Derive isRecording from coordinator state machine
Mar 20, 2026
d55f96d
Merge branch 'main' into refactor/derive-isrecording-from-state
yazins-ai Mar 20, 2026
7d9cd1b
Merge branch 'main' into refactor/derive-isrecording-from-state
yazins-ai Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions OpenOats/Sources/OpenOats/App/AppCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,11 +67,9 @@ final class AppCoordinator {
set { withMutation(keyPath: \.requestedSessionSelectionID) { _requestedSessionSelectionID = newValue } }
}

/// Reflects whether a transcription session is currently active (set by ContentView).
@ObservationIgnored nonisolated(unsafe) private var _isRecording = false
var isRecording: Bool {
get { access(keyPath: \.isRecording); return _isRecording }
set { withMutation(keyPath: \.isRecording) { _isRecording = newValue } }
if case .recording = state { return true }
return false
}

@ObservationIgnored nonisolated(unsafe) private var _sessionHistory: [SessionIndex] = []
Expand Down
12 changes: 12 additions & 0 deletions OpenOats/Sources/OpenOats/Meeting/MeetingTypes.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,4 +67,16 @@ struct MeetingMetadata: Sendable, Equatable, Codable {
let title: String?
let startedAt: Date
var endedAt: Date?

static func manual() -> MeetingMetadata {
let now = Date()
return MeetingMetadata(
detectionContext: DetectionContext(
signal: .manual, detectedAt: now,
meetingApp: nil, calendarEvent: nil
),
calendarEvent: nil, title: nil,
startedAt: now, endedAt: nil
)
}
}
15 changes: 1 addition & 14 deletions OpenOats/Sources/OpenOats/Views/ContentView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,19 +328,7 @@ struct ContentView: View {
}

suggestionEngine?.clear()
let metadata = MeetingMetadata(
detectionContext: DetectionContext(
signal: .manual,
detectedAt: Date(),
meetingApp: nil,
calendarEvent: nil
),
calendarEvent: nil,
title: nil,
startedAt: Date(),
endedAt: nil
)
coordinator.handle(.userStarted(metadata), settings: settings)
coordinator.handle(.userStarted(.manual()), settings: settings)
}

private func stopSession() {
Expand Down Expand Up @@ -548,7 +536,6 @@ struct ContentView: View {

if currentViewState.isRunning != observedIsRunning {
observedIsRunning = currentViewState.isRunning
coordinator.isRecording = currentViewState.isRunning
}

let pendingExternalCommandID = coordinator.pendingExternalCommand?.id
Expand Down