Global clean and code issues fix

.github/workflows/build.yml

@@ -113,8 +113,8 @@ jobs:
             libxcb-icccm4-dev libxcb-keysyms1-dev libxcb-dri2-0-dev libxcb-dri3-dev
             libxcb-glx0-dev libx11-xcb-dev libglu1-mesa-dev
             libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev
-            libegl1-mesa-dev mono-complete
-          version: 1.0
+            libegl1-mesa-dev mono-complete libxtst-dev libltdl-dev
+          version: 1.1
           execute_install_scripts: true
 
       - name: Install .NET SDK 9.0

.github/workflows/codeql.yml

@@ -66,8 +66,8 @@ jobs:
             libxcb-icccm4-dev libxcb-keysyms1-dev libxcb-dri2-0-dev libxcb-dri3-dev
             libxcb-glx0-dev libx11-xcb-dev libglu1-mesa-dev
             libxrender-dev libxi-dev libxkbcommon-dev libxkbcommon-x11-dev
-            libegl1-mesa-dev mono-complete
-          version: 1.0
+            libegl1-mesa-dev mono-complete libxtst-dev libltdl-dev
+          version: 1.1
           execute_install_scripts: true
 
       - name: Install .NET SDK 9.0

CMakeLists.txt

@@ -17,13 +17,21 @@ set(NEXO_GRAPHICS_API "OpenGL" CACHE STRING "Graphics API to use")
 if (CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
     set(NEXO_COMPILER_FLAGS_ALL --std=c++${CMAKE_CXX_STANDARD})
     set(NEXO_COMPILER_FLAGS_DEBUG -g -Wmissing-field-initializers -Wall -Wextra -Wpedantic)
-    set(NEXO_COMPILER_FLAGS_RELEASE -O3)
+    set(NEXO_COMPILER_FLAGS_RELEASE -O3 -DNDEBUG)
     set(NEXO_COVERAGE_FLAGS -O0 --coverage)
+
+    set(NEXO_LINKER_FLAGS_ALL "")
+    set(NEXO_LINKER_FLAGS_DEBUG "")
+    set(NEXO_LINKER_FLAGS_RELEASE "-flto")
 elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
     set(NEXO_COMPILER_FLAGS_ALL /nologo /W4 /std:c++${CMAKE_CXX_STANDARD} /Zc:preprocessor /utf-8)
     set(NEXO_COMPILER_FLAGS_DEBUG /Zi /Od /Zc:preprocessor /MDd /D_DEBUG /D_ITERATOR_DEBUG_LEVEL=2 /D_SECURE_SCL=1)
-    set(NEXO_COMPILER_FLAGS_RELEASE /O2 /Zc:preprocessor)
+    set(NEXO_COMPILER_FLAGS_RELEASE /O2 /Zc:preprocessor /DNDEBUG /MD)
     set(NEXO_COVERAGE_FLAGS "")  # MSVC doesn't support coverage in the same way
+
+    set(NEXO_LINKER_FLAGS_ALL "")
+    set(NEXO_LINKER_FLAGS_DEBUG "")
+    set(NEXO_LINKER_FLAGS_RELEASE "/LTCG")
 else()
     message(WARNING "Unsupported compiler: ${CMAKE_CXX_COMPILER_ID}, using default flags")
 endif()
@@ -34,6 +42,12 @@ add_compile_options(
         "$<$<CONFIG:Release>:${NEXO_COMPILER_FLAGS_RELEASE}>"
 )
 
+add_link_options(
+        "${NEXO_LINKER_FLAGS_ALL}"
+        "$<$<CONFIG:Debug>:${NEXO_LINKER_FLAGS_DEBUG}>"
+        "$<$<CONFIG:Release>:${NEXO_LINKER_FLAGS_RELEASE}>"
+)
+
 # Prevent Visual Studio (or other build tools) from creating per config sub-directories (e.g. Debug, Release)
 # Useful to look for resource files relative to the executable path
 set(CMAKE_RUNTIME_OUTPUT_DIRECTORY $<1:${CMAKE_BINARY_DIR}>)

common/Logger.hpp

@@ -54,15 +54,16 @@ namespace nexo {
 
     inline std::string toString(const LogLevel level)
     {
+        using enum LogLevel;
         switch (level)
         {
-            case LogLevel::FATAL: return "FATAL";
-            case LogLevel::ERR: return "ERROR";
-            case LogLevel::WARN: return "WARN";
-            case LogLevel::INFO: return "INFO";
-            case LogLevel::USER: return "USER";
-            case LogLevel::DEBUG: return "DEBUG";
-            case LogLevel::DEV: return "DEV";
+            case FATAL: return "FATAL";
+            case ERR: return "ERROR";
+            case WARN: return "WARN";
+            case INFO: return "INFO";
+            case USER: return "USER";
+            case DEBUG: return "DEBUG";
+            case DEV: return "DEV";
         }
         return "UNKNOWN";
     }

editor/CMakeLists.txt

@@ -47,6 +47,7 @@ set(SRCS
         editor/src/DocumentWindows/EditorScene/Shortcuts.cpp
         editor/src/DocumentWindows/EditorScene/Show.cpp
         editor/src/DocumentWindows/EditorScene/Shutdown.cpp
+        editor/src/DocumentWindows/EditorScene/Timecode.cpp
         editor/src/DocumentWindows/EditorScene/Toolbar.cpp
         editor/src/DocumentWindows/EditorScene/Update.cpp
         editor/src/DocumentWindows/EditorScene/DragDrop.cpp

editor/main.cpp

@@ -16,46 +16,46 @@
 //
 ///////////////////////////////////////////////////////////////////////////////
 
-#include "src/Editor.hpp"
+#include "src/DocumentWindows/AssetManager/AssetManagerWindow.hpp"
 #include "src/DocumentWindows/ConsoleWindow/ConsoleWindow.hpp"
 #include "src/DocumentWindows/EditorScene/EditorScene.hpp"
-#include "src/DocumentWindows/SceneTreeWindow/SceneTreeWindow.hpp"
 #include "src/DocumentWindows/InspectorWindow/InspectorWindow.hpp"
-#include "src/DocumentWindows/AssetManager/AssetManagerWindow.hpp"
 #include "src/DocumentWindows/MaterialInspector/MaterialInspector.hpp"
 #include "src/DocumentWindows/PrimitiveWindow/PrimitiveWindow.hpp"
-#include "src/DocumentWindows/GameWindow/GameWindow.hpp"
+#include "src/DocumentWindows/SceneTreeWindow/SceneTreeWindow.hpp"
+#include "src/Editor.hpp"
 
-#include <thread>
-#include <loguru.hpp>
 #include <core/exceptions/Exceptions.hpp>
+#include <loguru.hpp>
+#include <thread>
 
 #include "scripting/native/ManagedTypedef.hpp"
 #include "scripting/native/Scripting.hpp"
 
 int main(int argc, char **argv)
 try {
     loguru::init(argc, argv);
-    loguru::g_stderr_verbosity = loguru::Verbosity_3;
+    loguru::g_stderr_verbosity   = loguru::Verbosity_3;
     nexo::editor::Editor &editor = nexo::editor::Editor::getInstance();
 
     editor.registerWindow<nexo::editor::EditorScene>(
-        std::format("Default Scene{}{}", NEXO_WND_USTRID_DEFAULT_SCENE, 0)
-    );
+        std::format("Default Scene{}{}", NEXO_WND_USTRID_DEFAULT_SCENE, 0));
     editor.registerWindow<nexo::editor::SceneTreeWindow>(NEXO_WND_USTRID_SCENE_TREE);
     editor.registerWindow<nexo::editor::InspectorWindow>(NEXO_WND_USTRID_INSPECTOR);
     editor.registerWindow<nexo::editor::ConsoleWindow>(NEXO_WND_USTRID_CONSOLE);
     editor.registerWindow<nexo::editor::MaterialInspector>(NEXO_WND_USTRID_MATERIAL_INSPECTOR);
     editor.registerWindow<nexo::editor::PrimitiveWindow>(NEXO_WND_USTRID_PRIMITIVE_WINDOW);
     editor.registerWindow<nexo::editor::AssetManagerWindow>(NEXO_WND_USTRID_ASSET_MANAGER);
 
-    if (const auto defaultScene = editor.getWindow<nexo::editor::EditorScene>(std::format("Default Scene{}{}", NEXO_WND_USTRID_DEFAULT_SCENE, 0)).lock())
+    if (const auto defaultScene = editor
+                                      .getWindow<nexo::editor::EditorScene>(
+                                          std::format("Default Scene{}{}", NEXO_WND_USTRID_DEFAULT_SCENE, 0))
+                                      .lock())
         defaultScene->setDefault();
 
     editor.init();
 
-    while (editor.isOpen())
-    {
+    while (editor.isOpen()) {
         auto start = std::chrono::high_resolution_clock::now();
         editor.render();
         editor.update();

editor/src/ADocumentWindow.cpp

@@ -21,51 +21,48 @@
 
 namespace nexo::editor {
 
-    void ADocumentWindow::beginRender(const std::string &windowName)
+    void ADocumentWindow::beginRender(const std::string& windowName)
     {
         dockingUpdate(windowName);
         visibilityUpdate();
         sizeUpdate();
     }
 
-    void ADocumentWindow::dockingUpdate(const std::string &windowName)
+    void ADocumentWindow::dockingUpdate(const std::string& windowName)
     {
-        if (const ImGuiWindow* currentWindow = ImGui::GetCurrentWindow(); currentWindow)
-        {
-            const bool isDocked = currentWindow->DockIsActive;
+        if (const ImGuiWindow* currentWindow = ImGui::GetCurrentWindow(); currentWindow) {
+            const bool isDocked         = currentWindow->DockIsActive;
             const ImGuiID currentDockID = currentWindow->DockId;
-            const auto dockId = m_windowRegistry.getDockId(windowName);
+            const auto dockId           = m_windowRegistry.getDockId(windowName);
 
-            // If it's the first time opening the window and we have a dock id saved in the registry, then we force set it
+            // If it's the first time opening the window and we have a dock id saved in the registry, then we force set
+            // it
             if (m_firstOpened && (dockId && currentDockID != *dockId))
                 ImGui::DockBuilderDockWindow(windowName.c_str(), *dockId);
             // If the docks ids differ, it means the window got rearranged in the global layout
-            // If we are docked but we dont have a dock id saved in the registry, it means the user moved the window
+            // If we are docked, but we don't have a dock id saved in the registry, it means the user moved the window
             // In both cases, we update our docking registry with the new dock id
             else if ((dockId && currentDockID != *dockId) || (isDocked && !dockId))
                 m_windowRegistry.setDockId(windowName, currentDockID);
 
-
             // If it is not docked anymore, we have a floating window without docking node,
             // So we erase it from the docking registry
-            if (!m_firstOpened && !isDocked)
-                m_windowRegistry.resetDockId(windowName);
+            if (!m_firstOpened && !isDocked) m_windowRegistry.resetDockId(windowName);
             m_firstOpened = false;
         }
     }
 
     void ADocumentWindow::visibilityUpdate()
     {
-        m_focused = ImGui::IsWindowFocused();
-        const bool isDocked = ImGui::IsWindowDocked();
+        m_focused                 = ImGui::IsWindowFocused();
+        const bool isDocked       = ImGui::IsWindowDocked();
         const ImGuiWindow* window = ImGui::GetCurrentWindow();
 
         if (isDocked) {
             // If the window is currently being rendered with normal content,
             // and not hidden or set to skip items, then it is visible
             m_isVisibleInDock = !window->Hidden && !window->SkipItems && window->Active;
-        }
-        else {
+        } else {
             // Not docked windows are visible if we've reached this point
             m_isVisibleInDock = true;
         }
@@ -75,10 +72,10 @@ namespace nexo::editor {
     void ADocumentWindow::sizeUpdate()
     {
         const ImGuiWindow* window = ImGui::GetCurrentWindow();
-        m_windowPos = window->Pos;
-        m_windowSize = window->Size;
-        m_contentSizeMin = ImGui::GetWindowContentRegionMin();
-        m_contentSizeMax = ImGui::GetWindowContentRegionMax();
-        m_contentSize = ImGui::GetContentRegionAvail();
+        m_windowPos               = window->Pos;
+        m_windowSize              = window->Size;
+        m_contentSizeMin          = ImGui::GetWindowContentRegionMin();
+        m_contentSizeMax          = ImGui::GetWindowContentRegionMax();
+        m_contentSize             = ImGui::GetContentRegionAvail();
     }
-}
+} // namespace nexo::editor