Skip to content

[EN COURS] fix issue 1666 : modales#1667

Open
cyrilphoenix71 wants to merge 1 commit intodevelopfrom
fix_1666
Open

[EN COURS] fix issue 1666 : modales#1667
cyrilphoenix71 wants to merge 1 commit intodevelopfrom
fix_1666

Conversation

@cyrilphoenix71
Copy link
Contributor

@cyrilphoenix71 cyrilphoenix71 commented Jan 20, 2020 •
edited
Loading

fix #1666
Add blur when modale

To test :

  • check if height of modals is ok now with height résolution change
  • check all the update page (modale log, update counters etc)
  • check all the backup page (modal log, backup, restore)
  • test modale icon selector
  • check the scenarios' log modals

NE PAS MERGER

@vinceg77
Copy link
Contributor

vinceg77 commented Jan 21, 2020 •
edited
Loading

I would add to test :

  • check the scenarios' log modals

@iWils iWils self-requested a review January 21, 2020 22:54
iWils
iWils approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@iWils iWils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR testé et validé.

  • L'effet blur est bien présent sur les fonds lors de l'affichage des modales

  • Les modales ce redimensionne bien en largueur et en hauteur.

@cyrilphoenix71 cyrilphoenix71 changed the title fix issue 1666 : modales height [EN COURS] fix issue 1666 : modales Jan 24, 2020
@cyrilphoenix71
fix 1666
f4c4a5f 
fix #1666


fix sonar


fix


Modification ajax et manager

optimize notif update


phase 2


fix


increment update


fix
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 18, 2020

SonarCloud Quality Gate failed.

Bug C 6 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iWils iWils iWils approved these changes

@therealcorwin therealcorwin Awaiting requested review from therealcorwin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hauteur modale mal gérée

3 participants

@cyrilphoenix71 @vinceg77 @iWils