Skip to content

Allow configurable qos #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Allow configurable qos #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
baf76c9
allow configurable qos
rromanchuk May 30, 2023
75cad73
try again
rromanchuk May 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions Sources/NextLevelSessionExporter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ open class NextLevelSessionExporter: NSObject {
/// Audio output configuration dictionary, using keys defined in `<AVFoundation/AVAudioSettings.h>`
public var audioOutputConfiguration: [String : Any]?



/// Export session status state.
public var status: AVAssetExportSession.Status {
get {
Expand Down Expand Up @@ -129,6 +131,8 @@ open class NextLevelSessionExporter: NSObject {
fileprivate var _pixelBufferAdaptor: AVAssetWriterInputPixelBufferAdaptor?

fileprivate var _inputQueue: DispatchQueue
/// Assign custom priority on global dispatch queue
fileprivate var _qos: DispatchQoS.QoSClass

fileprivate var _videoOutput: AVAssetReaderVideoCompositionOutput?
fileprivate var _audioOutput: AVAssetReaderAudioMixOutput?
Expand All @@ -149,13 +153,21 @@ open class NextLevelSessionExporter: NSObject {
/// Initializes a session with an asset to export.
///
/// - Parameter asset: The asset to export.
public convenience init(withAsset asset: AVAsset) {
self.init()
public convenience init(withAsset asset: AVAsset, qos: DispatchQoS.QoSClass = .default) {
self.init(qos: qos)
self.asset = asset
}

public init(qos: DispatchQoS.QoSClass) {
self._qos = qos
self._inputQueue = DispatchQueue(label: InputQueueLabel, autoreleaseFrequency: .workItem, target: DispatchQueue.global(qos: _qos))
self.timeRange = CMTimeRange(start: CMTime.zero, end: CMTime.positiveInfinity)
super.init()
}

public override init() {
self._inputQueue = DispatchQueue(label: InputQueueLabel, autoreleaseFrequency: .workItem, target: DispatchQueue.global())
self._qos = .default
self._inputQueue = DispatchQueue(label: InputQueueLabel, autoreleaseFrequency: .workItem, target: DispatchQueue.global(qos: _qos))
self.timeRange = CMTimeRange(start: CMTime.zero, end: CMTime.positiveInfinity)
super.init()
}
Expand Down Expand Up @@ -302,7 +314,7 @@ extension NextLevelSessionExporter {
audioSemaphore.signal()
}

DispatchQueue.global().async {
DispatchQueue.global(qos: _qos).async {
audioSemaphore.wait()
videoSemaphore.wait()
DispatchQueue.main.async {
Expand Down