Refactor FcmService to support batch sending of FCM messages and impr…#32
Merged
Refactor FcmService to support batch sending of FCM messages and impr…#32
Conversation
…ove error handling
Test Results32 tests 32 ✅ 0s ⏱️ Results for commit 0c23e10. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the notification dispatch and FCM sending logic to improve batch processing, error handling, and code clarity. The main changes include switching from single-message sending to batch sending in
FcmService, updating notification dispatch to leverage batch sending, and simplifying the notification message builder.Notification dispatch and FCM sending improvements:
FcmServiceto addsendEach, enabling batch sending of FCM messages with improved error handling and token cleanup for invalid tokens. The previous single-messagesendmethod was removed, and batch size is capped at 500.NotificationDispatchServiceto use batch sending viaFcmService.sendEach, group tokens by member, and track notification status more accurately. Removed dependency onFcmTokenServicein favor of direct repository access.Notification message builder simplification:
ProfileRepositoryand logger fromNotificationMessageBuilder, and added atoDatamethod toNotificationMessagefor easy conversion to FCM data format. [1] [2] [3]Policy fallback logic improvement:
WorkdayServiceto provide a fallback to the latest available policy if none is found for the requested date.…ove error handling