Add logging to notification batch schedulers and make FcmTokenReposit…#33
Merged
Add logging to notification batch schedulers and make FcmTokenReposit…#33
Conversation
…ory deleteByToken transactional
Test Results32 tests 32 ✅ 0s ⏱️ Results for commit b646773. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces logging for batch notification schedulers and improves transaction handling in the FCM token repository. The main changes are as follows:
Logging Enhancements:
NotificationBatchSchedulerandPaydayNotificationBatchScheduler, logging the execution time and type of batch job each time the scheduled tasks run. [1] [2]Repository Improvements:
deleteByTokenmethod inFcmTokenRepositorywith@Transactionalto ensure proper transaction management during token deletion.…ory deleteByToken transactional