Conversation
… with member ID context and Change Android Notification Priority
Test Results32 tests 32 ✅ 0s ⏱️ Results for commit fa25891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to logging and error handling in the application, focusing on better traceability of requests and user actions. The main changes include adding MDC-based logging for request and member identifiers, enhancing exception logging, and updating log configuration for improved clarity. Additionally, push notification configuration is updated for higher priority delivery.
Logging enhancements:
MdcLoggingFilterto inject a shortrequestIdinto MDC for each request, log request start/end, and clear MDC after each request, improving traceability across logs. (src/main/kotlin/com/moa/common/filter/MdcLoggingFilter.kt)AuthMemberResolverandOnboardingAuthMemberResolverto add the authenticatedmemberIdto MDC, enabling user-level tracking in logs. (src/main/kotlin/com/moa/common/auth/AuthMemberResolver.kt,src/main/kotlin/com/moa/common/auth/OnboardingAuthMemberResolver.kt) [1] [2]Log configuration:
logback-spring.xmlconfiguration file to format logs withrequestIdandmemberId, and set log levels for local and production environments. (src/main/resources/logback-spring.xml)Exception handling improvements:
GlobalExceptionHandlerto log HTTP method, URI, and error code for unauthorized and forbidden exceptions, providing better context for security-related issues. (src/main/kotlin/com/moa/common/exception/GlobalExceptionHandler.kt)Push notification configuration:
FcmServiceto set Android push notification priority toHIGH, ensuring faster delivery of important messages. (src/main/kotlin/com/moa/service/FcmService.kt)Miscellaneous:
show_sql: truefrom Hibernate properties in the local Spring configuration to reduce log noise. (src/main/resources/application-local.yml)… with member ID context and Change Android Notification Priority