feat: Add default node storage location preference #690
Conversation
kalidatony
commented
Feb 27, 2025
kalidatony
commented
- Introduced new storage preferences section in app settings
- Added ability to set and change default node storage location
- Implemented storage location selection with free space information
- Updated translations and preload interfaces to support new feature
- Introduced new storage preferences section in app settings - Added ability to set and change default node storage location - Implemented storage location selection with free space information - Updated translations and preload interfaces to support new feature
✅ Deploy Preview for nndesign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
hey @kalidatony thanks! Just took a quick look at the diffs. It looks like the first part of this is done, UI and saving the setting. Second part would be using this as the default storage path instead of the previous default (I believe its something like electron.appStorage). Not a must, but we could do a permissions check on the directory path that the user chooses to make sure they have write permissions. If you don't mind, see if installing biomejs in cursor/vscode, the tool we use for formatting, to see if that prevents things like single quote to double quote diffs. |
- Implemented write permission validation when selecting storage location - Added error handling and user notification for permission denied scenarios - Updated files to support custom default storage location with fallback - Added new translations for permission-related error messages
|
@jgresham I have added the changes, Please check |
excellent. I will test it out across different machines/OSs over the next few days |
|
Hey I didn't forget about this, I've just been away from my hardware for testing! |
it's alright man. Thank you |
|
Hi @jgresham . Hope you are well. Have you been able to check it out? |
|
@kalidatony can you revert the changes from ' to ’ |
|
@kalidatony and revert the ' to " for the import lines |
| } | ||
|
|
||
| // Fall back to default app storage location | ||
| const userDataPath = app.getPath('userData'); |
There was a problem hiding this comment.
keep this logic the same, so it should be just return path.join(getNNDirPath(), 'nodes')
|
@kalidatony I tested this on mac and windows and it doesnt work |
2 participants
