Js-commons integration baseline [WIP] #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…them still need to be migrated, such as settings validation)
… functions for browser and node platforms
… test until telemetry is included
…ation_updated_e2e_offline
…e2e_offline Updated offline E2E tests
…e2e_tests updated E2E tests
…gration Using JS-commons utils
…ns base settings validation
…_validation Js-commons integration: settings validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JS SDK
What did you accomplish?
Removed modules to use JS-commons modules.
Updated index.js to use the modular SDK factory from JS-commons.
How do we test the changes introduced in this PR?
TODO: validate with Browser and Node E2E tests
Extra Notes