Check string keys in APNS::Notifications message hash#46
Open
lserman wants to merge 1 commit intoNicosKaralis:masterfrom
lserman:patch-1
Open
Check string keys in APNS::Notifications message hash#46lserman wants to merge 1 commit intoNicosKaralis:masterfrom lserman:patch-1
lserman wants to merge 1 commit intoNicosKaralis:masterfrom
lserman:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When queuing a message through Redis (Sidekiq in my case), hash parameters are serialized and unserialized via JSON dump/load, so any symbol keys are converted to strings. Since APNS::Notification only checks symbol keys, the push will fail unless you symbolize the keys again after the body is given to the Sidekiq worker.
This PR will check for string keys in addition to symbol keys so that this situation can be avoided.