Draft
Conversation
Still need to implement SNR method in class
…an issue in the main MAPS repository
Still completely untested
JAX is a dependency of Optimistix already
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added JAX functionality through the anis_pta_jax.py file and an example notebook. Everything is documented. I tried installing my fork in a fresh conda environment (with enterprise) and the example notebook ran.
This is not the most efficient way to do JAX-based anisotropy analyses, but it was difficult to make something both general and highly-optimized, so I went for generality in this module. I also did not use object-oriented programming because functional programming is easier for me.
pip installing this package will not give GPU compatibility by default, but will if the user installs the CUDA version of JAX.