Draft
Conversation
* Move config-reading abstract methods from each decider into a ConfigReader Interface * Add featureGroup support to control what features use the same hashing for proportionOfUsers decider * Move the provided config decider predicates to a single class as static factory methods that depend on a ConfigReader instead of separate abstract classes that must be implemented in a specific config module
jrduncans
force-pushed
the
moirai-3.x
branch
from
36dcc60 to
f5a34d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigReader Interface
for proportionOfUsers decider
static factory methods that depend on a ConfigReader instead of separate
abstract classes that must be implemented in a specific config module