This repository was archived by the owner on Apr 19, 2021. It is now read-only.
Use UTF-8 encoding when saving emails #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thierry BLIND <tbl0605@gmail.com>
|
This UTF-8 encoding issue on save is indeed a "problematic" issue (okay, not a "bouh, blocker, I cannot work!" issue, but still major) because the results you get in your local tests with FakeSMTP do not match the resulst on production. @Nilhcem Can you review, approve, merge & deploy this (or decline for whatever reason)? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I recently used FakeSMTP to look at my generated emails.
All my emails looked wrong (in Outlook), because all utf-8 characters seemed to be wrongly encoded.
Problem (and solution) is simple: FakeSMTP reads an utf-8 InputStream in method MailSaver #convertStreamToString(InputStream is), so it should also save the stream as an utf-8 file in method MailSaver#saveEmailToFile(String mailContent).
Thierry.