feat: app://instructions + trim /settings panel to workspace-config only#7
Open
mgoldsborough wants to merge 1 commit intomainfrom
Open
feat: app://instructions + trim /settings panel to workspace-config only#7mgoldsborough wants to merge 1 commit intomainfrom
mgoldsborough wants to merge 1 commit intomainfrom
Conversation
Wire collateral up to NimbleBrain's bundle-side custom-instructions contract and remove the duplicate edit surfaces between the platform /settings panel and the in-app Settings drawer. Server side: - Publish `app://instructions` returning the same body as `voice.md`. The platform reads it on every prompt assembly and wraps non-empty output in `<app-custom-instructions>` containment, so the manual voice → skill-resource splice is gone. - Cap `set_voice` at 8 KiB UTF-8 (mirrors `MAX_INSTRUCTIONS_BYTES`). Empty content clears the file. Cap violations return a structured tool error rather than crossing the wire as a transport failure. - Trim the inline settings HTML to **Theme** and **Custom Instructions** only. Components and Assets are removed — they're authoring surfaces, not workspace-wide config, and the in-app views are the canonical home for both. In-app side: - Promote Components to a top-level view (`ComponentsView` + tab). - Delete `SettingsPanel` and the Settings button in TopNav. Voice now lives only in /settings (Custom Instructions); Components is a tab. - Replace `useBrand` with a focused `useComponents` hook. Tests: - 10 new tests in `tests/test_custom_instructions.py` covering the resource round-trip, empty-clears-file, byte cap (including multibyte UTF-8), and that the skill resource no longer inlines voice content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires Collateral Studio up to NimbleBrain's bundle-side custom-instructions contract (`app://instructions`) and resolves the duplicate edit surfaces between the platform's `/settings/workspace/apps/synapse-collateral` panel and the in-app Settings drawer.
Principle applied
`/settings/workspace/apps/` is the canonical home for workspace-wide config that affects agent behavior even when nobody's in the app's UI. The in-app UI is for authoring (documents, templates, components, assets). The two surfaces should not duplicate each other.
Server changes (`src/mcp_collateral/`)
In-app changes (`ui/src/`)
Tests
10 new tests in `tests/test_custom_instructions.py` covering:
`uv run pytest tests/` → 103 passed.
Test plan
Related
installLocal(path-based install) nimblebrain#101 (orphan data-dir bug between `installLocal` and `installNamed` — platform-side fix needed before this works correctly across both install paths).