Skip to content

added new Iphones viewports#9

Open
michaeleparkour wants to merge 1 commit intoNimbleworks:masterfrom
michaeleparkour:patch-2
Open

added new Iphones viewports#9
michaeleparkour wants to merge 1 commit intoNimbleworks:masterfrom
michaeleparkour:patch-2

Conversation

@michaeleparkour
Copy link
Copy Markdown

No description provided.

@johnnye
Copy link
Copy Markdown
Member

johnnye commented Sep 22, 2014

There is quite a lot going on in this commit that makes it difficult to see the wood for the trees.
I would prefer 2 commits if possible,

  • 1 for the new iPhone sizes
  • another for the reordering of devices (which seems to be a sensible thing to put in).

I appreciate the support and contributions - I might reject the pull request and do the two commit separately. Although it will have to wait until tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants