Server rewrite in rust with self contained binary#2
Draft
TAINCER wants to merge 7 commits intorelease-candidatefrom
Draft
Server rewrite in rust with self contained binary#2TAINCER wants to merge 7 commits intorelease-candidatefrom
TAINCER wants to merge 7 commits intorelease-candidatefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rewrite in rust of the frontend server implmentation, currently in NodeJS. This is currently WIP, with a implentation reference of the NodeJS server renamed to
server-node.The primary motivation is, the database and other json files being contained in the binary itself, thus not depending on files in other places. This speeds up the server, needs fewer resources, but also eliminates all possible path traversal vulnerabilities, like in a previous PR of mine (Pax1601#939). It also means no NodeJS runtime is needed on the server
This version has full feature parity with the NodeJS server. This also given free TS types for the react frontend, if needed but it's out of the scope of this PR. It's currently still in progress. This for the folloing is implemented.