Skip to content

Remove confusing handleNoteFill behaviour during playback#212

Merged
asiekierka merged 1 commit intoNitrousTracker:newfrom
prayerie:patch-11
Mar 14, 2026
Merged

Remove confusing handleNoteFill behaviour during playback#212
asiekierka merged 1 commit intoNitrousTracker:newfrom
prayerie:patch-11

Conversation

@prayerie
Copy link
Copy Markdown

No description provided.

@exelotl
Copy link
Copy Markdown

exelotl commented Mar 12, 2026

This seems like a positive change to me. It:

  • removes a feature where you can clear a swathe of the song by holding down clr while it's playing.
  • fixes a bug where this feature would be activated even when scroll lock is enabled - i.e. you'd try to clear a note and accidentally clear the whole row instead.

I think the clr feature was very unexpected and I don't believe many people will be using it or even know about it, so it's fine for it to go.

@prayerie
Copy link
Copy Markdown
Author

prayerie commented Mar 12, 2026

This seems like a positive change to me. It:

  • removes a feature where you can clear a swathe of the song by holding down clr while it's playing.

  • fixes a bug where this feature would be activated even when scroll lock is enabled - i.e. you'd try to clear a note and accidentally clear the whole row instead.

I think the clr feature was very unexpected and I don't believe many people will be using it or even know about it, so it's fine for it to go.

I'm not even sure why this was a thing. Does FT2 do this? (i assume not)

edit: either way, i feel like it is just more intuitive to make a selection and clear notes that way..

@asiekierka asiekierka merged commit 9932660 into NitrousTracker:new Mar 14, 2026
1 check passed
@asiekierka
Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants