listbox.cpp: calcScrollThingy in ins and del#223
Merged
asiekierka merged 1 commit intoNitrousTracker:newfrom Mar 19, 2026
Merged
listbox.cpp: calcScrollThingy in ins and del#223asiekierka merged 1 commit intoNitrousTracker:newfrom
asiekierka merged 1 commit intoNitrousTracker:newfrom
Conversation
Collaborator
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210, an issue where pressing "ins" or "del" beside the pattern order table listbox wouldn't update the scrollbar.
ins()anddel()seem to be designed towards user-caused insertions/deletions, and only the pattern order table listbox seems use these functions, so there seem to be no efficiency concerns regarding other listboxes that update many elements at once.