Refactor/extract services from server#172
Merged
Nitya-003 merged 3 commits intoNitya-003:mainfrom Mar 8, 2026
Merged
Conversation
❌ Deploy Preview for roaring-ganache-c7465f failed. Why did it fail? →
|
Contributor
Author
|
Hi @maintainer, This PR involves a major backend refactor — extracting multiple services from the Could you please update the label to hard? Thank you! |
Collaborator
|
@navin-oss pls resolve conflicts |
Nitya-003
requested changes
Mar 7, 2026
Owner
Nitya-003
left a comment
There was a problem hiding this comment.
@navin-oss Can you please mention the issue number you are solving? Can you resolve the conflicts?
Collaborator
Contributor
Author
|
Resloved conflicts |
Nitya-003
requested changes
Mar 8, 2026
Owner
Nitya-003
left a comment
There was a problem hiding this comment.
@navin-oss Closes #154 and Resolve the conflicts.
Contributor
Author
|
Resolved conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successfully refactored the
backend/server.js"God file" into dedicated services following the Separation of Concerns principle. The new branchrefactor/extract-services-from-serverhas been pushed to the remote.Created Services:
1.
BlockchainServicecreateBatchOnChain(),updateBatchOnChain(),getBatchFromChain(),simulateHash()blockchain.jsconfig2.
BatchServicegenerateBatchId(),generateQRCode(),createBatch(),getBatch(),updateBatch(),recallBatch(),getAllBatches(),calculateStats(),getDashboardStats()3.
NotificationServicealertRecall(),sendRecallNotification(),notifyBatchCreated(),notifyBatchUpdated(),notifySecurityEvent(),notifyError()4. Refactored
server.jsBenefits:
Branch Details:
refactor/extract-services-from-server