fix: critical security vulnerability in wallet authentication and add…#194
Merged
Nitya-003 merged 1 commit intoNitya-003:mainfrom Mar 8, 2026
Merged
Conversation
Contributor
navin-oss
commented
Mar 8, 2026
navin-oss
commented
- Fix nonce validation in walletLogin and walletRegister to prevent replay attacks
- Always require stored nonce instead of falling back to constant string
- Return 401 error if no nonce exists for the address
- Add missing controller functions to batchController.js:
- createBatch - handles batch creation with transaction support
- getBatch - retrieves single batch by ID
- getAllBatches - alias for getBatches (consistency)
- updateBatch - handles batch updates with stage transitions
- recallBatch - admin-only batch recall functionality
- These functions prevent future import errors if routes are extracted from server.js
… missing batch controller functions - Fix nonce validation in walletLogin and walletRegister to prevent replay attacks * Always require stored nonce instead of falling back to constant string * Return 401 error if no nonce exists for the address - Add missing controller functions to batchController.js: * createBatch - handles batch creation with transaction support * getBatch - retrieves single batch by ID * getAllBatches - alias for getBatches (consistency) * updateBatch - handles batch updates with stage transitions * recallBatch - admin-only batch recall functionality - These functions prevent future import errors if routes are extracted from server.js
❌ Deploy Preview for roaring-ganache-c7465f failed. Why did it fail? →
|
Nitya-003
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.