Skip to content

cabal2nix/FromCabal.License: use getLicenseFromSpdxId for SPDX licenses #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sternenseemann merged 1 commit into from
Mar 21, 2026
+3 −2
Merged

cabal2nix/FromCabal.License: use getLicenseFromSpdxId for SPDX licenses #708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cabal2nix/src/Distribution/Nixpkgs/Haskell/FromCabal/License.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,8 @@ fromSPDXLicense (SPDX.License expr) =
SPDX.ELicense simpl Nothing ->
-- Not handled: license exceptions
case simpl of
SPDX.ELicenseId lid -> Known ("lib.licensesSpdx.\"" ++ prettyShow lid ++ "\"")
-- FIXME(@sternenseemann): this is not exactly Known, but a best effort lookup
SPDX.ELicenseId lid -> Known ("lib.meta.getLicenseFromSpdxId \"" ++ prettyShow lid ++ "\"")
_ ->
-- Not handed: the '+' suffix and user-defined licences references.
-- Use the SPDX expression as a free-form license string.
Expand Down
2 changes: 1 addition & 1 deletion cabal2nix/test/golden-test-cases/pandoc.nix.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ mkDerivation {
];
homepage = "https://pandoc.org";
description = "Conversion between markup formats";
license = lib.licensesSpdx."GPL-2.0-or-later";
license = lib.meta.getLicenseFromSpdxId "GPL-2.0-or-later";
mainProgram = "pandoc";
}
Loading