dmd: fix for #138376

[lionello]

Motivation for this change

This is a suggested fix for #138376: autoPatchelfHook could not satisfy dependency ld-linux.so.2. I don't have a Linux machine to test this right now, but will spin up a VM.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• 21.11 Release Notes (or backporting 21.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[dukc]

No, this does not work. GLibc is already in propagatedBuildInputs and adding it to native build inputs changes nothing, at least for me. For me it seems it's looking for a linker, as a run-time dependency (but it wouldn't be first time I'm misreading error messages). I wonder why it compiled before but stopped now?

[trofi]

If it's of any help dmd started failing after this change:

commit b79483d
Author: Noah Fontes noah@noahfontes.com
Date: Sun Sep 12 15:07:15 2021 -0700

autoPatchelfHook: fix detection under crossSystem

In #84415, autoPatchelfHook was taught to use the correct path to the
readelf binary when a crossSystem is specified. Unfortunately, the
remainder of the functionality in the script depended on ldd, which only
reads ELF files of its own architecture. It has the further unfortunate
quality of not reporting any useful error, but rather that the file is
not a dynamic executable.

This change uses patchelf to directly analyze the DT_NEEDED tags in the
target files instead, which correctly works across architectures. It
also updates the use of objdump to be prefix-aware $OBJDUMP (which would
have been required in the PR mentioned above, but we never made it that
far into the script execution).

pkgs/build-support/setup-hooks/auto-patchelf.sh | 95 ++++++++++++++++++-------
1 file changed, 71 insertions(+), 24 deletions(-)

[lionello]

Should've been fixed by #137886

[dukc]

Let's assume so for now. It hasn't hit the unstable channel in Hydra yet, though. I'll wait for that and then test.

[dukc]

Sorry a bit late with the testing, but yes DMD 2.097 now builds again with unstable channel on NixOS.