Skip to content

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for beancount is: Double-entry bookkeeping computer language

meta.homepage for beancount is: https://github.com/beancount/beancount

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 3.0.0 with grep in /nix/store/lpyzf2fpf9nxkxzq9xk0cnbx07v7xcd3-python3.12-beancount-3.0.0
  • found 3.0.0 in filename of file in /nix/store/lpyzf2fpf9nxkxzq9xk0cnbx07v7xcd3-python3.12-beancount-3.0.0

Rebuild report (if merged into master) (click to expand)
8 total rebuild path(s)

8 package rebuild(s)

First fifty rebuilds by attrpath

beancount
fava
ledger2beancount
python311Packages.beancount
python311Packages.beancount-docverif
python312Packages.beancount
python312Packages.beancount-docverif
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/lpyzf2fpf9nxkxzq9xk0cnbx07v7xcd3-python3.12-beancount-3.0.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A beancount https://github.com/r-ryantm/nixpkgs/archive/267e62266f445c2bba001ed70e143cea0661ec80.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/267e62266f445c2bba001ed70e143cea0661ec80#beancount

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/lpyzf2fpf9nxkxzq9xk0cnbx07v7xcd3-python3.12-beancount-3.0.0
ls -la /nix/store/lpyzf2fpf9nxkxzq9xk0cnbx07v7xcd3-python3.12-beancount-3.0.0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages failed to build:
  • fava
  • fava.dist
9 packages built:
  • beancount (python312Packages.beancount)
  • beancount.dist (python312Packages.beancount.dist)
  • ledger2beancount
  • python311Packages.beancount
  • python311Packages.beancount-docverif
  • python311Packages.beancount-docverif.dist
  • python311Packages.beancount.dist
  • python312Packages.beancount-docverif
  • python312Packages.beancount-docverif.dist

Maintainer pings

cc @bhipple for testing.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jul 18, 2024
@ofborg ofborg bot requested a review from bhipple July 18, 2024 00:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 18, 2024
@denisfalqueto
Copy link
Contributor

denisfalqueto commented Jul 18, 2024

This should not be accepted, because it breaks Fava and beancount 3.0 is not yet stable enough. See #327531

@natsukium natsukium marked this pull request as draft July 28, 2024 03:57
@matthiasbeyer
Copy link
Contributor

They did release 3.0.0 but it is not stable? 😕

@denisfalqueto
Copy link
Contributor

They did release 3.0.0 but it is not stable? 😕

From what I could gather, version 3.0 is stable for Beancount, but breaks Fava. Beancount was divided into subprojects, with beanbulp being the tool responsible for importing data abd Fava is not compatible with beangulp yet.

@kilianar
Copy link
Contributor

Would it be reasonable to have both versions in nixpkgs? We could set version 3 as the default while keeping version 2 available for programs like fava that still depend on the older version. There are already pull requests to package the components that have been moved to subprojects (#325917, #325901), which rely on this update.

@matthiasbeyer
Copy link
Contributor

Would it be reasonable to have both versions in nixpkgs? We could set version 3 as the default while keeping version 2 available for programs like fava [...]

If and only if 2 and 3 are compatible and using 3 on CLI while using 2 for fava does not result in users being unable to use one of both versions.

But TBH I would just wait until fava catches up!

@Prince213
Copy link
Member

Fava 1.30 has released with Beancount v3 support (see changelog here), so I think we can reconsider merging this?

@matthiasbeyer
Copy link
Contributor

@denisfalqueto what do you think?

@denisfalqueto
Copy link
Contributor

denisfalqueto commented Dec 30, 2024

@denisfalqueto what do you think?

I think that's great! Let's test it!

@seberm
Copy link
Contributor

seberm commented Jan 15, 2025

I would close this PR in favour of #371541

@matthiasbeyer
Copy link
Contributor

I would close this PR in favour of #371541

Agreed.

@r-ryantm r-ryantm deleted the auto-update/beancount branch January 17, 2025 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants