-
-
Notifications
You must be signed in to change notification settings - Fork 17.7k
beancount: 2.3.6 -> 3.0.0 #328055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beancount: 2.3.6 -> 3.0.0 #328055
Conversation
|
This should not be accepted, because it breaks Fava and beancount 3.0 is not yet stable enough. See #327531 |
|
They did release 3.0.0 but it is not stable? 😕 |
From what I could gather, version 3.0 is stable for Beancount, but breaks Fava. Beancount was divided into subprojects, with beanbulp being the tool responsible for importing data abd Fava is not compatible with beangulp yet. |
|
Would it be reasonable to have both versions in nixpkgs? We could set version 3 as the default while keeping version 2 available for programs like fava that still depend on the older version. There are already pull requests to package the components that have been moved to subprojects (#325917, #325901), which rely on this update. |
If and only if 2 and 3 are compatible and using 3 on CLI while using 2 for fava does not result in users being unable to use one of both versions. But TBH I would just wait until fava catches up! |
|
@denisfalqueto what do you think? |
I think that's great! Let's test it! |
|
I would close this PR in favour of #371541 |
Agreed. |
Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for beancount is: Double-entry bookkeeping computer language
meta.homepage for beancount is: https://github.com/beancount/beancount
Updates performed
To inspect upstream changes
Impact
Checks done
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
Or:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-reviewrun on x86_64-linux 12 packages failed to build:
9 packages built:
Maintainer pings
cc @bhipple for testing.