recaf: init at 2.21.14, recaf_4: init at 4.0-unstable-2024-11-03#354184
recaf: init at 2.21.14, recaf_4: init at 4.0-unstable-2024-11-03#354184pluiedev wants to merge 2 commits intoNixOS:masterfrom
Conversation
|
looks like it got a merge conflict :( |
What are the odds that someone just happens to add an entry to all-packages.nix at the exact same spot that I did... EDIT: Nevermind, appears to be something caught up by the by-name migration |
8497fba to
6ea2d8a
Compare
|
Duplicate of #350589? |
That one doesn't package recaf 2.x though, which is still technically the stable release branch |
|
Result of 2 packages failed to build:
|
Both builds still succeed for me 🤷🏼♀️ Can you send me the logs where it failed? |
here ya go |
|
|
That's really odd. Lemme try to update to the latest commit for Recaf 4 though I have absolutely zero idea why the tests are failing for Recaf 2 |
|
I decided to just update to a slightly newer commit for Recaf 4 and disable the failing tests for Recaf 2 |
|
|
What's the status of this? |
| # Needed for automatic version detection - build script will fail without it | ||
| leaveDotGit = true; |
There was a problem hiding this comment.
Would be better to patch the build script
There was a problem hiding this comment.
It's uhm... Not trivial. I actually tried going that route, but the way it works is that it generates a Java source file containing version metadata and it's not easy to call that generator outside of Gradle. If someone wants to tackle this, they can, but this is outside my paygrade
Very confused as to why the builds are working for me but not for other people |
|
@ofborg build recaf recaf_4 |
|
|
||
| nativeBuildInputs = [ makeBinaryWrapper ]; | ||
|
|
||
| mvnHash = "sha256-MPPZXQilmMaj8n5SXP7fG1Q95pH5Ydu7jU+KRS9beO8="; |
There was a problem hiding this comment.
| mvnHash = "sha256-MPPZXQilmMaj8n5SXP7fG1Q95pH5Ydu7jU+KRS9beO8="; | |
| mvnHash = "sha256-QwkUgTF/a0ZY2RN8fvlVBsMECo9ijUCRB7nuW7zIt/Y="; |
on x64 Linux.
Fixes #267124
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.