Skip to content

nixosTests/stardust-xr-server: init #355256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Pandapip1 wants to merge 4 commits into from
Closed

nixosTests/stardust-xr-server: init #355256

Pandapip1 wants to merge 4 commits into from

Conversation

@Pandapip1
Copy link
Member

@Pandapip1 Pandapip1 commented Nov 11, 2024 •
edited
Loading

Modified from upstream: https://github.com/StardustXR/server/blob/main/nix/gnome-graphical-test.nix; untested

The result should look like:

screen

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 11, 2024
@Pandapip1 Pandapip1 force-pushed the stardust-xr-add-nixos-tets branch from 236cebb to ba2b406 Compare November 11, 2024 19:42
@Pandapip1 Pandapip1 changed the title Stardust xr add nixos tets nixosTests/stardust-xr-server: init Nov 11, 2024
@Pandapip1 Pandapip1 force-pushed the stardust-xr-add-nixos-tets branch from ba2b406 to f0a7319 Compare November 11, 2024 19:54
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 12, 2024
@Pandapip1 Pandapip1 force-pushed the stardust-xr-add-nixos-tets branch 2 times, most recently from 8ed26ec to fce3656 Compare November 12, 2024 22:45
@Pandapip1 Pandapip1 force-pushed the stardust-xr-add-nixos-tets branch from fce3656 to c21b0d3 Compare November 12, 2024 23:33
@ofborg ofborg bot requested review from Scrumplex and prusnak November 13, 2024 12:35
@ofborg ofborg bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 13, 2024
Scrumplex
Scrumplex approved these changes Nov 16, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

nixos/tests/stardust-xr-server.nix
machine.wait_for_unit("stardust-xr-server.service", "${user.name}")
machine.wait_for_unit("flatland.service", "${user.name}")
machine.wait_for_unit("weston-cliptest.service", "${user.name}")
machine.sleep(3)
Copy link
Member

@Scrumplex Scrumplex Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be flaky when built on a busy machine

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 17, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 10, 2024
@wegank wegank removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jan 3, 2025
@nixpkgs-ci nixpkgs-ci bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 25, 2025
@Pandapip1
Copy link
Member Author

Pandapip1 commented Oct 30, 2025

Closing, will be superseded

@Pandapip1 Pandapip1 closed this Oct 30, 2025
@Pandapip1
Copy link
Member Author

Pandapip1 commented Nov 7, 2025

#457027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@prusnak prusnak Awaiting requested review from prusnak

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Pandapip1 @Scrumplex @wegank