Skip to content

lumafly: use dotnet sdk 9 as sdk 7 has been marked insecure #360640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corngood merged 1 commit into from
Dec 13, 2024
Merged

lumafly: use dotnet sdk 9 as sdk 7 has been marked insecure #360640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 31 additions & 11 deletions pkgs/by-name/lu/lumafly/package.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
icoutils,
copyDesktopItems,
makeDesktopItem,
writeScript,
}:
buildDotnetModule rec {
pname = "lumafly";
Expand All @@ -17,18 +18,33 @@ buildDotnetModule rec {
src = fetchFromGitHub {
owner = "TheMulhima";
repo = "lumafly";
rev = "v${version}";
rev = "refs/tags/v${version}";
hash = "sha256-GVPMAwxbq9XlKjMKd9G5yUol42f+6lSyHukN7NMCVDA=";
};

# Use .NET 9.0 since 7.0 is EOL
dotnetFlags = [ "-p:TargetFramework=net9.0" ];

projectFile = "Lumafly/Lumafly.csproj";

nugetDeps = ./deps.nix;

dotnet-sdk = dotnetCorePackages.sdk_7_0;
dotnet-sdk = dotnetCorePackages.sdk_9_0;
dotnet-runtime = dotnetCorePackages.sdk_9_0;

selfContainedBuild = true;

passthru.updateScript = writeScript "update-lumafly" ''
#!/usr/bin/env nix-shell
#!nix-shell --pure -i bash -p bash nix nix-update git cacert
set -eo pipefail

prev_version=$(nix eval --raw -f. lumafly.version)
nix-update lumafly
[[ $(nix eval --raw -f. lumafly.version) == "$prev_version" ]] ||
$(nix-build . -A lumafly.fetch-deps --no-out-link)
'';

runtimeDeps = [
zlib
icu
Expand All @@ -40,21 +56,25 @@ buildDotnetModule rec {
copyDesktopItems
];

executables = [ "Lumafly" ];

postFixup = ''
# Icon for the desktop file
icotool -x $src/Lumafly/Assets/Lumafly.ico
install -D Lumafly_1_32x32x32.png $out/share/icons/hicolor/32x32/apps/lumafly.png
'';

desktopItems = [(makeDesktopItem {
desktopName = "Lumafly";
name = "lumafly";
exec = "Lumafly";
icon = "lumafly";
comment = meta.description;
type = "Application";
categories = [ "Game" ];
})];
desktopItems = [
(makeDesktopItem {
desktopName = "Lumafly";
name = "lumafly";
exec = "Lumafly";
icon = "lumafly";
comment = "A cross platform mod manager for Hollow Knight written in Avalonia";
type = "Application";
categories = [ "Game" ];
})
];

meta = {
description = "A cross platform mod manager for Hollow Knight written in Avalonia";
Expand Down