Skip to content

Comments

haskellPackages.postgres-websockets: fix at run-time#407098

Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
wolfgangwalther:postgres-websockets
May 16, 2025
Merged

haskellPackages.postgres-websockets: fix at run-time#407098
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
wolfgangwalther:postgres-websockets

Conversation

@wolfgangwalther
Copy link
Contributor

Reason for the failure is still unclear and it was not possible to reproduce upstream, yet.

diogob/postgres-websockets#101 (comment)

I will want to have that fix in 25.05 eventually, too, but I figured merging into haskell-updates and then backporting after branch-off might be better, to reduce the merge conflicts in main.yml, which was recently sorted and now added to.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 14, 2025
@nix-owners nix-owners bot requested review from maralorn and sternenseemann May 14, 2025 18:33
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 14, 2025
@wolfgangwalther
Copy link
Contributor Author

I was able to reproduce the problem by changing the NixOS test to produce a mode: r token instead of mode: rw. The test broke before and passed after this change.

The upstream issue is diogob/postgres-websockets#105 and is being worked on. So depending on when we'd like to merge haskell-updates, we can either merge this or wait for the fix.

@sternenseemann sternenseemann added the 9.needs: port to stable A PR needs a backport to the stable release. label May 14, 2025
@sternenseemann
Copy link
Member

Since it looks like there may be a fix in the very near future, may be worth waiting on that for a bit?

@wolfgangwalther
Copy link
Contributor Author

Fix is being worked on in diogob/postgres-websockets#106, so yes this will be available soon.

@wolfgangwalther
Copy link
Contributor Author

Fix is available in https://github.com/diogob/postgres-websockets/releases/tag/0.11.2.4.

Shall we do another bump?

@sternenseemann
Copy link
Member

sternenseemann commented May 16, 2025

Given that the current iteration is ready, I'd prefer manually updating it or applying it as a patch because we can merge immediately after.

@wolfgangwalther
Copy link
Contributor Author

Will do!

Reason for the failure is still unclear and it was not possible to
reproduce outside nixpkgs, yet.

diogob/postgres-websockets#101 (comment)
@wolfgangwalther
Copy link
Contributor Author

I went with the patch, because that will fail the build for us on update automatically. Had to apply another one to make it apply.

Also confirmed with the nixosTests that this still works and also fixes the mode: r bug. All good.

@wolfgangwalther wolfgangwalther merged commit d816f53 into NixOS:haskell-updates May 16, 2025
17 of 21 checks passed
@wolfgangwalther wolfgangwalther deleted the postgres-websockets branch May 16, 2025 10:04
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented May 16, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot added the 8.has: port to stable This PR already has a backport to the stable release. label May 16, 2025
@wolfgangwalther wolfgangwalther removed the 9.needs: port to stable A PR needs a backport to the stable release. label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants