[25.05] nix-tree: 0.6.1 -> 0.6.3#426475
Conversation
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Please follow the backporting guidelines and cherry-pick with the -x flag.
This requires changes to the unstable master and staging branches first, before backporting them.
Occasionally, it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts or when updating minor versions of packages which have already advanced to the next major on unstable.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Couldn't locate original commit hash in message of 9c836aefe36cb6a63df69da7e3d0f5f29c0dd8a8.
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
utdemir
left a comment
There was a problem hiding this comment.
I appreciate your work - and sorry for being late to release which caused all these!
However - I'm not involved with nixpkgs Haskell Team, so I do not know about their view of updating (auto-generated) hackage-packages.nix by hand. So I'm unable to approve/reject the PR.
|
|
Please use https://github.com/NixOS/nixpkgs/blob/nixos-25.05/pkgs/development/haskell-modules/replacements-by-name/README.md, see e.g. #364210. You can easily generate the necessary package expression using |
Haskell backports can't be facilitated by cherry-picking commits from master.
9c836ae to
20fbdc6
Compare
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Please follow the backporting guidelines and cherry-pick with the -x flag.
This requires changes to the unstable master and staging branches first, before backporting them.
Occasionally, it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts or when updating minor versions of packages which have already advanced to the next major on unstable.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Couldn't locate original commit hash in message of 20fbdc60e0c04345788ca24b739ea6a9f4a5822f.
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
Haskell updates can't be cherry-picked individually.
|
The commit message shouldn't have the |
20fbdc6 to
4b7d727
Compare
There was a problem hiding this comment.
This report is automatically generated by the PR / Check / cherry-pick CI workflow.
Some of the commits in this PR require the author's and reviewer's attention.
Please follow the backporting guidelines and cherry-pick with the -x flag.
This requires changes to the unstable master and staging branches first, before backporting them.
Occasionally, it is not possible to cherry-pick exactly the same patch.
This most frequently happens when resolving merge conflicts or when updating minor versions of packages which have already advanced to the next major on unstable.
If you need to merge this PR despite the warnings, please dismiss this review shortly before merging.
Warning
Couldn't locate original commit hash in message of 4e91eee.
Hint: The full diffs are also available in the runner logs with slightly better highlighting.
|
|
I meant that there shouldn't be a prefix in brackets at all. Commit message format guideline is the same for all branches. |
selective manual backport of version bump hand picked new version/hash from haskell package update in NixOS#413046
4b7d727 to
4e91eee
Compare
Oh my. Sorry for keeping you busy with this. Should be fine now. |
|
|
@sternenseemann to avoid so many repeated reviews requesting changes by CI, you can dismiss the review shortly before merge. When a not-dismissed-yet review is still there, this will only be updated and a new one will not be created. |
selective manual backport of version bump
hand picked new version/hash from haskell package update in #413046
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.