Skip to content

replaceVars: work around content-addressed output path shenanigans #439003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timschumi wants to merge 1 commit into from
Closed

replaceVars: work around content-addressed output path shenanigans #439003

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions pkgs/build-support/replace-vars/replace-vars-with.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,25 @@ let
preferLocalBuild = true;
allowSubstitutes = false;

# Due to NixOS/nix#12361 the placeholder paths of content-addressed derivations
Copy link
Copy Markdown
Contributor

@philiptaron philiptaron Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This meta-issue doesn't actually explain the behavior here described. Is there a more specific issue?

Copy link
Copy Markdown
Member Author

@timschumi timschumi Sep 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen anything that would be more specific than "this output path has a weird format", and this seemed to have been the only issue relating to this in the nix namespace. But probably a moot discussion point anyway, since we ideally want to fix this without disabling the described behavior.

# do not follow the expected format, it lacks the `storeDir` and (more importantly)
# the `name`.
# This breaks assumptions of some downstream users of replaceVars, notably being able
# to filter out patches using their name:
# $ nix build -f. rocmPackages.clang --arg config '{ contentAddressedByDefault = true; }'
# [...]
# > applying patch /nix/store/8va99vng26z2pqlhvsva787rkqnqw8j4-clang-at-least-16-LLVMgold-path.patch
# > patching file lib/Driver/ToolChains/CommonArgs.cpp
# > Hunk #1 succeeded at 775 (offset 186 lines).
# [...]
# > applying patch /nix/store/8va99vng26z2pqlhvsva787rkqnqw8j4-clang-at-least-16-LLVMgold-path.patch
# > patching file lib/Driver/ToolChains/CommonArgs.cpp
# > Reversed (or previously applied) patch detected! Assume -R? [n]
# > Apply anyway? [n]
# > Skipping patch.
# > 1 out of 1 hunk ignored -- saving rejects to file lib/Driver/ToolChains/CommonArgs.cpp.rej
__contentAddressed = false;

buildPhase = ''
runHook preBuild

Expand Down
Loading