rocmPackages.llvm: remove workaround for LLVMgold-path.patch#457624
Merged
fabianhjr merged 2 commits intoNixOS:masterfrom Nov 11, 2025
Merged
rocmPackages.llvm: remove workaround for LLVMgold-path.patch#457624fabianhjr merged 2 commits intoNixOS:masterfrom
fabianhjr merged 2 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
Member
With some incredible timing I wiped my stored ca-derivation build today due to being low on space on my testing machine, so it will take me some time to report back with results. That said, from looking at just the diff it should solve the issue I had just fine. |
emilazy
reviewed
Nov 2, 2025
Member
Author
|
Prior to overrideScope support for llvmPackages, LLVMgold-path.patch would point at a non-overridden LLVM and needed replaced. Now that we use overrideScope we can drop this patch.
add-nostdlibinc-flag.patch is no longer needed as it was moved to the cc-wrapper
LunNova
force-pushed
the
push-ysrottxkvwwl
branch
from
73b592a to
6ff66dc
Compare
Flakebi
approved these changes
Nov 3, 2025
nixpkgs-ci
Bot
added
the
12.approvals: 1
fabianhjr
approved these changes
Nov 11, 2025
nixpkgs-ci
Bot
added
12.approvals: 2
hatch01
pushed a commit
to hatch01/nixpkgs
that referenced
this pull request
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to overrideScope support for llvmPackages, LLVMgold-path.patch would point at a non-overridden LLVM and needed replaced.
Now that we use overrideScope we can drop this jank!
This should hopefully resolve the issue where rocmPackages didn't work with CA derivations.
See also #439003
cc @timschumi
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.